Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/installtion instructions.md #160

Closed

Conversation

JaytidaA
Copy link
Contributor

@JaytidaA JaytidaA commented Feb 5, 2025

Further work for resolving Issue #148

  • Changed three pictures which went under my notice that still contained the version 5.1 of the ESP IDF command prompt and powershell.

Installations.md Outdated
@@ -7,7 +7,7 @@
# For Windows
The first step is to install the ESP-IDF v4.2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update IDF version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, am commiting the changes now

Copy link

@NachtSpyder04 NachtSpyder04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any image being properly displayed in Markdown. Please verify

Also update the title of PR to [Documentation] : Update Installation instructions

* Changed the odd instance of v4.2 to v5.2
* Updated the installation instructions for MacOS
Removed an incorrect line from a previous commit
</p>

### Step 7: Open ESP-IDF 4.2 CMD which should be on your desktop
### Step 7: Open ESP-IDF 5.2 PowerShell which should be on your desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaytidaA you haven't updated your fork before pushing these changes. This has caused the same changes to appear which have been done previously which might result in merge conflicts

@Shankari02 Shankari02 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants